This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/16488 ) Change subject: bankd: Fix log print during removeMapping ...................................................................... bankd: Fix log print during removeMapping We need to dereference 'rreq' nor 'creq' in the remove handling. Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a --- M src/bankd/bankd_main.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 7851a2b..7b50a73 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -190,11 +190,11 @@ rreq = &pdu->msg.choice.removeMappingReq; if (rreq->bank.bankId != g_bankd->srvc.bankd.bank_id) { LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Bank ID %lu " - "(we are %u)\n", creq->bank.bankId, g_bankd->srvc.bankd.bank_id); + "(we are %u)\n", rreq->bank.bankId, g_bankd->srvc.bankd.bank_id); resp = rspro_gen_RemoveMappingRes(ResultCode_illegalBankId); } else if (rreq->bank.slotNr >= g_bankd->srvc.bankd.num_slots) { LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Slot Nr %lu " - "(we have %u)\n", creq->bank.slotNr, g_bankd->srvc.bankd.num_slots); + "(we have %u)\n", rreq->bank.slotNr, g_bankd->srvc.bankd.num_slots); resp = rspro_gen_RemoveMappingRes(ResultCode_illegalSlotId); } else { rspro2bank_slot(&bs, &rreq->bank); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/16488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a Gerrit-Change-Number: 16488 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191204/38e67d73/attachment.htm>