<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16488">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd: Fix log print during removeMapping<br><br>We need to dereference 'rreq' nor 'creq' in the remove handling.<br><br>Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a<br>---<br>M src/bankd/bankd_main.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c</span><br><span>index 7851a2b..7b50a73 100644</span><br><span>--- a/src/bankd/bankd_main.c</span><br><span>+++ b/src/bankd/bankd_main.c</span><br><span>@@ -190,11 +190,11 @@</span><br><span>          rreq = &pdu->msg.choice.removeMappingReq;</span><br><span>             if (rreq->bank.bankId != g_bankd->srvc.bankd.bank_id) {</span><br><span>                        LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Bank ID %lu "</span><br><span style="color: hsl(0, 100%, 40%);">-                               "(we are %u)\n", creq->bank.bankId, g_bankd->srvc.bankd.bank_id);</span><br><span style="color: hsl(120, 100%, 40%);">+                             "(we are %u)\n", rreq->bank.bankId, g_bankd->srvc.bankd.bank_id);</span><br><span>                   resp = rspro_gen_RemoveMappingRes(ResultCode_illegalBankId);</span><br><span>                 } else if (rreq->bank.slotNr >= g_bankd->srvc.bankd.num_slots) {</span><br><span>                    LOGPFSML(srvc->fi, LOGL_ERROR, "removeMapping specifies invalid Slot Nr %lu "</span><br><span style="color: hsl(0, 100%, 40%);">-                               "(we have %u)\n", creq->bank.slotNr, g_bankd->srvc.bankd.num_slots);</span><br><span style="color: hsl(120, 100%, 40%);">+                          "(we have %u)\n", rreq->bank.slotNr, g_bankd->srvc.bankd.num_slots);</span><br><span>                        resp = rspro_gen_RemoveMappingRes(ResultCode_illegalSlotId);</span><br><span>                 } else {</span><br><span>                     rspro2bank_slot(&bs, &rreq->bank);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/16488">change 16488</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/16488"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I04e9e2447336f7d1aaeb932928a79bb705aa0c5a </div>
<div style="display:none"> Gerrit-Change-Number: 16488 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>