Change in libosmocore[master]: gsm48_ie.c: Avoid compiler warnings about using deprecated API

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16474 )


Change subject: gsm48_ie.c: Avoid compiler warnings about using deprecated API
......................................................................

gsm48_ie.c: Avoid compiler warnings about using deprecated API

We shouldn't use deprecated API even inside libosmocore.

gsm48_ie.c: In function ‘gsm48_decode_called’:
gsm48_ie.c:411:2: warning: ‘gsm48_decode_bcd_number’ is deprecated: Use gsm48_decode_bcd_number2() for improved bounds checking [-Wdeprecated-declarations]
  411 |  gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1);
      |  ^~~~~~~~~~~~~~~~~~~~~~~
gsm48_ie.c:54:5: note: declared here
   54 | int gsm48_decode_bcd_number(char *output, int output_len,
      |     ^~~~~~~~~~~~~~~~~~~~~~~
gsm48_ie.c: In function ‘gsm48_decode_callerid’:
gsm48_ie.c:466:2: warning: ‘gsm48_decode_bcd_number’ is deprecated: Use gsm48_decode_bcd_number2() for improved bounds checking [-Wdeprecated-declarations]
  466 |  gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i);
      |  ^~~~~~~~~~~~~~~~~~~~~~~
gsm48_ie.c:54:5: note: declared here
   54 | int gsm48_decode_bcd_number(char *output, int output_len,
      |     ^~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I0e5cd06a70556e624bfed0d52405d232d8296dbc
---
M src/gsm/gsm48_ie.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/16474/1

diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c
index 31028ba..fd96575 100644
--- a/src/gsm/gsm48_ie.c
+++ b/src/gsm/gsm48_ie.c
@@ -408,7 +408,7 @@
 	called->type = (lv[1] & 0x70) >> 4;
 
 	/* octet 4..N */
-	gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1);
+	gsm48_decode_bcd_number2(called->number, sizeof(called->number), lv, in_len+1, 1);
 
 	return 0;
 }
@@ -463,7 +463,7 @@
 	}
 
 	/* octet 4..N */
-	gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i);
+	gsm48_decode_bcd_number2(callerid->number, sizeof(callerid->number), lv, in_len+1, i);
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16474
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e5cd06a70556e624bfed0d52405d232d8296dbc
Gerrit-Change-Number: 16474
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191204/19a6ab78/attachment.htm>