<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16474">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm48_ie.c: Avoid compiler warnings about using deprecated API<br><br>We shouldn't use deprecated API even inside libosmocore.<br><br>gsm48_ie.c: In function ‘gsm48_decode_called’:<br>gsm48_ie.c:411:2: warning: ‘gsm48_decode_bcd_number’ is deprecated: Use gsm48_decode_bcd_number2() for improved bounds checking [-Wdeprecated-declarations]<br>  411 |  gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1);<br>      |  ^~~~~~~~~~~~~~~~~~~~~~~<br>gsm48_ie.c:54:5: note: declared here<br>   54 | int gsm48_decode_bcd_number(char *output, int output_len,<br>      |     ^~~~~~~~~~~~~~~~~~~~~~~<br>gsm48_ie.c: In function ‘gsm48_decode_callerid’:<br>gsm48_ie.c:466:2: warning: ‘gsm48_decode_bcd_number’ is deprecated: Use gsm48_decode_bcd_number2() for improved bounds checking [-Wdeprecated-declarations]<br>  466 |  gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i);<br>      |  ^~~~~~~~~~~~~~~~~~~~~~~<br>gsm48_ie.c:54:5: note: declared here<br>   54 | int gsm48_decode_bcd_number(char *output, int output_len,<br>      |     ^~~~~~~~~~~~~~~~~~~~~~~<br><br>Change-Id: I0e5cd06a70556e624bfed0d52405d232d8296dbc<br>---<br>M src/gsm/gsm48_ie.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/16474/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c</span><br><span>index 31028ba..fd96575 100644</span><br><span>--- a/src/gsm/gsm48_ie.c</span><br><span>+++ b/src/gsm/gsm48_ie.c</span><br><span>@@ -408,7 +408,7 @@</span><br><span>     called->type = (lv[1] & 0x70) >> 4;</span><br><span> </span><br><span>         /* octet 4..N */</span><br><span style="color: hsl(0, 100%, 40%);">-        gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ gsm48_decode_bcd_number2(called->number, sizeof(called->number), lv, in_len+1, 1);</span><br><span> </span><br><span>         return 0;</span><br><span> }</span><br><span>@@ -463,7 +463,7 @@</span><br><span>         }</span><br><span> </span><br><span>        /* octet 4..N */</span><br><span style="color: hsl(0, 100%, 40%);">-        gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i);</span><br><span style="color: hsl(120, 100%, 40%);">+     gsm48_decode_bcd_number2(callerid->number, sizeof(callerid->number), lv, in_len+1, i);</span><br><span> </span><br><span>     return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16474">change 16474</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16474"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0e5cd06a70556e624bfed0d52405d232d8296dbc </div>
<div style="display:none"> Gerrit-Change-Number: 16474 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>