Change in osmo-sgsn[master]: check for osmo_fsm_register() error return values

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Dec 1 12:43:17 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16362 )

Change subject: check for osmo_fsm_register() error return values
......................................................................

check for osmo_fsm_register() error return values

Change-Id: I2028c82ac1b0421101c3f5d04fd999b65abdbf08
---
M src/sgsn/gprs_gmm_attach.c
M src/sgsn/gprs_gmm_fsm.c
M src/sgsn/gprs_mm_state_gb_fsm.c
M src/sgsn/gprs_mm_state_iu_fsm.c
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sgsn/gprs_gmm_attach.c b/src/sgsn/gprs_gmm_attach.c
index 130f8d1..c903a01 100644
--- a/src/sgsn/gprs_gmm_attach.c
+++ b/src/sgsn/gprs_gmm_attach.c
@@ -449,7 +449,7 @@
 
 static __attribute__((constructor)) void gprs_gmm_fsm_init(void)
 {
-	osmo_fsm_register(&gmm_attach_req_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&gmm_attach_req_fsm) == 0);
 }
 
 void gmm_att_req_free(struct sgsn_mm_ctx *mm) {
diff --git a/src/sgsn/gprs_gmm_fsm.c b/src/sgsn/gprs_gmm_fsm.c
index fac06f2..94ecb50 100644
--- a/src/sgsn/gprs_gmm_fsm.c
+++ b/src/sgsn/gprs_gmm_fsm.c
@@ -183,5 +183,5 @@
 
 static __attribute__((constructor)) void gmm_fsm_init(void)
 {
-	osmo_fsm_register(&gmm_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&gmm_fsm) == 0);
 }
diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c
index f6d680c..811f0c2 100644
--- a/src/sgsn/gprs_mm_state_gb_fsm.c
+++ b/src/sgsn/gprs_mm_state_gb_fsm.c
@@ -125,5 +125,5 @@
 
 static __attribute__((constructor)) void mm_state_gb_fsm_init(void)
 {
-	osmo_fsm_register(&mm_state_gb_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&mm_state_gb_fsm) == 0);
 }
diff --git a/src/sgsn/gprs_mm_state_iu_fsm.c b/src/sgsn/gprs_mm_state_iu_fsm.c
index ea31941..e571026 100644
--- a/src/sgsn/gprs_mm_state_iu_fsm.c
+++ b/src/sgsn/gprs_mm_state_iu_fsm.c
@@ -146,5 +146,5 @@
 
 static __attribute__((constructor)) void mm_state_iu_fsm_init(void)
 {
-	osmo_fsm_register(&mm_state_iu_fsm);
+	OSMO_ASSERT(osmo_fsm_register(&mm_state_iu_fsm) == 0);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16362
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2028c82ac1b0421101c3f5d04fd999b65abdbf08
Gerrit-Change-Number: 16362
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/180498bf/attachment.htm>


More information about the gerrit-log mailing list