<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16362">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check for osmo_fsm_register() error return values<br><br>Change-Id: I2028c82ac1b0421101c3f5d04fd999b65abdbf08<br>---<br>M src/sgsn/gprs_gmm_attach.c<br>M src/sgsn/gprs_gmm_fsm.c<br>M src/sgsn/gprs_mm_state_gb_fsm.c<br>M src/sgsn/gprs_mm_state_iu_fsm.c<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm_attach.c b/src/sgsn/gprs_gmm_attach.c</span><br><span>index 130f8d1..c903a01 100644</span><br><span>--- a/src/sgsn/gprs_gmm_attach.c</span><br><span>+++ b/src/sgsn/gprs_gmm_attach.c</span><br><span>@@ -449,7 +449,7 @@</span><br><span> </span><br><span> static __attribute__((constructor)) void gprs_gmm_fsm_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        osmo_fsm_register(&gmm_attach_req_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(osmo_fsm_register(&gmm_attach_req_fsm) == 0);</span><br><span> }</span><br><span> </span><br><span> void gmm_att_req_free(struct sgsn_mm_ctx *mm) {</span><br><span>diff --git a/src/sgsn/gprs_gmm_fsm.c b/src/sgsn/gprs_gmm_fsm.c</span><br><span>index fac06f2..94ecb50 100644</span><br><span>--- a/src/sgsn/gprs_gmm_fsm.c</span><br><span>+++ b/src/sgsn/gprs_gmm_fsm.c</span><br><span>@@ -183,5 +183,5 @@</span><br><span> </span><br><span> static __attribute__((constructor)) void gmm_fsm_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        osmo_fsm_register(&gmm_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(osmo_fsm_register(&gmm_fsm) == 0);</span><br><span> }</span><br><span>diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c</span><br><span>index f6d680c..811f0c2 100644</span><br><span>--- a/src/sgsn/gprs_mm_state_gb_fsm.c</span><br><span>+++ b/src/sgsn/gprs_mm_state_gb_fsm.c</span><br><span>@@ -125,5 +125,5 @@</span><br><span> </span><br><span> static __attribute__((constructor)) void mm_state_gb_fsm_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  osmo_fsm_register(&mm_state_gb_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(osmo_fsm_register(&mm_state_gb_fsm) == 0);</span><br><span> }</span><br><span>diff --git a/src/sgsn/gprs_mm_state_iu_fsm.c b/src/sgsn/gprs_mm_state_iu_fsm.c</span><br><span>index ea31941..e571026 100644</span><br><span>--- a/src/sgsn/gprs_mm_state_iu_fsm.c</span><br><span>+++ b/src/sgsn/gprs_mm_state_iu_fsm.c</span><br><span>@@ -146,5 +146,5 @@</span><br><span> </span><br><span> static __attribute__((constructor)) void mm_state_iu_fsm_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  osmo_fsm_register(&mm_state_iu_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(osmo_fsm_register(&mm_state_iu_fsm) == 0);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16362">change 16362</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16362"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2028c82ac1b0421101c3f5d04fd999b65abdbf08 </div>
<div style="display:none"> Gerrit-Change-Number: 16362 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>