This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11083 )
Change subject: bts: Add module parameters with tolerance to support real HW
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@58
PS2, Line 58: mp_tolerance_ms_power_level
> tolerance doesn't make sense here. […]
If I recall correctly, what I read is that the value should match only if the MS supports it, and if the MS doesn't support it, then it should take a lower one the closest to the announced max value. I'll cross-check that.
I think I also saw at least once that the motorola phone announced a different power level (0?). I'll do some more tests and see how it behaves more in detail.
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@59
PS2, Line 59: mp_tolerance_ms_actual_ta := 0;
: integer mp_tolerance_timing_offset_256syms
> those two can be merged. […]
>From what I understand from your comment, then it doesn't matter which of the 2 values/variables we use since they have the same precision (despite one being in jumps of 256?). Or did I understand it incorrectly and the 256syms one has more precision?
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@62
PS2, Line 62: mp_ms_power_level_exp
> the expected power level must always match the instructed power level, otherwise the BTS or MS are b […]
As I said, I'll test it a bit more and come back with some descirption or change.
--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Sep 2018 18:01:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180926/db1eb65d/attachment.htm>