This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11083 )
Change subject: bts: Add module parameters with tolerance to support real HW
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@58
PS2, Line 58: mp_tolerance_ms_power_level
tolerance doesn't make sense here. the MS power level is instructed by the BTS to the MS, and the MS must transmit at the ordered power level back in uplink. There is no measurement involved. It is a digital value that must match.
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@59
PS2, Line 59: mp_tolerance_ms_actual_ta := 0;
: integer mp_tolerance_timing_offset_256syms
those two can be merged. As both the TA as well as the TOA256 are derived from the same timing measurement, there is only one source of determining timing distortion/error in the path. The 256syms value is of course 256 times the tolerance on the TA scale, which counts (if i remember correctly) in full symbols.
https://gerrit.osmocom.org/#/c/11083/2/bts/BTS_Tests.ttcn@62
PS2, Line 62: mp_ms_power_level_exp
the expected power level must always match the instructed power level, otherwise the BTS or MS are broken in some way. Making this value configurable doesn't appear to make much sense, IMHO.
--
To view, visit https://gerrit.osmocom.org/11083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 26 Sep 2018 17:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180926/af207ae9/attachment.htm>