This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11097 ) Change subject: lcls: log channel type and lchan names on LCLS codec mismatch ...................................................................... lcls: log channel type and lchan names on LCLS codec mismatch When a codec mismatch (lchan type or tch_mode does not match) occurs, we do not know which of the two lchan had which type or tch_mode. Lets print that information as well to make debugging easier. Change-Id: I3fd22fef50d8944ca8c003c6114fdda37417b2ea Related: OS#1602 --- M src/osmo-bsc/osmo_bsc_lcls.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c index 00c3296..b8bf601 100644 --- a/src/osmo-bsc/osmo_bsc_lcls.c +++ b/src/osmo-bsc/osmo_bsc_lcls.c @@ -276,13 +276,24 @@ if (conn->lchan->type != conn->lcls.other->lchan->type && conn->sccp.msc->lcls_codec_mismatch_allow == false) { - LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (channel type)\n"); + LOGPFSM(conn->lcls.fi, + "Not enabling LS due to channel type mismatch: %s:%s != %s:%s\n", + gsm_lchan_name(conn->lchan), + gsm_chan_t_name(conn->lchan->type), + gsm_lchan_name(conn->lcls.other->lchan), + gsm_chan_t_name(conn->lcls.other->lchan->type)); return false; } if (conn->lchan->tch_mode != conn->lcls.other->lchan->tch_mode && conn->sccp.msc->lcls_codec_mismatch_allow == false) { - LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (TCH-Mode)\n"); + LOGPFSM(conn->lcls.fi, + "Not enabling LS due to TCH-mode mismatch: %s:%s != %s:%s\n", + gsm_lchan_name(conn->lchan), + gsm48_chan_mode_name(conn->lchan->tch_mode), + gsm_lchan_name(conn->lcls.other->lchan), + gsm48_chan_mode_name(conn->lcls.other->lchan-> + tch_mode)); return false; } -- To view, visit https://gerrit.osmocom.org/11097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3fd22fef50d8944ca8c003c6114fdda37417b2ea Gerrit-Change-Number: 11097 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180926/969c1f2b/attachment.htm>