<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11097">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lcls: log channel type and lchan names on LCLS codec mismatch<br><br>When a codec mismatch (lchan type or tch_mode does not match) occurs, we<br>do not know which of the two lchan had which type or tch_mode. Lets<br>print that information as well to make debugging easier.<br><br>Change-Id: I3fd22fef50d8944ca8c003c6114fdda37417b2ea<br>Related: OS#1602<br>---<br>M src/osmo-bsc/osmo_bsc_lcls.c<br>1 file changed, 13 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>index 00c3296..b8bf601 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>@@ -276,13 +276,24 @@</span><br><span> </span><br><span>  if (conn->lchan->type != conn->lcls.other->lchan->type</span><br><span>            && conn->sccp.msc->lcls_codec_mismatch_allow == false) {</span><br><span style="color: hsl(0, 100%, 40%);">-              LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (channel type)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGPFSM(conn->lcls.fi,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "Not enabling LS due to channel type mismatch: %s:%s != %s:%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   gsm_lchan_name(conn->lchan),</span><br><span style="color: hsl(120, 100%, 40%);">+                       gsm_chan_t_name(conn->lchan->type),</span><br><span style="color: hsl(120, 100%, 40%);">+                     gsm_lchan_name(conn->lcls.other->lchan),</span><br><span style="color: hsl(120, 100%, 40%);">+                        gsm_chan_t_name(conn->lcls.other->lchan->type));</span><br><span>            return false;</span><br><span>        }</span><br><span> </span><br><span>        if (conn->lchan->tch_mode != conn->lcls.other->lchan->tch_mode</span><br><span>            && conn->sccp.msc->lcls_codec_mismatch_allow == false) {</span><br><span style="color: hsl(0, 100%, 40%);">-              LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (TCH-Mode)\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGPFSM(conn->lcls.fi,</span><br><span style="color: hsl(120, 100%, 40%);">+                     "Not enabling LS due to TCH-mode mismatch: %s:%s != %s:%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                       gsm_lchan_name(conn->lchan),</span><br><span style="color: hsl(120, 100%, 40%);">+                       gsm48_chan_mode_name(conn->lchan->tch_mode),</span><br><span style="color: hsl(120, 100%, 40%);">+                    gsm_lchan_name(conn->lcls.other->lchan),</span><br><span style="color: hsl(120, 100%, 40%);">+                        gsm48_chan_mode_name(conn->lcls.other->lchan-></span><br><span style="color: hsl(120, 100%, 40%);">+                                            tch_mode));</span><br><span>             return false;</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11097">change 11097</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11097"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3fd22fef50d8944ca8c003c6114fdda37417b2ea </div>
<div style="display:none"> Gerrit-Change-Number: 11097 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>