Change in osmo-bsc[master]: cosmetic: drop param from send_assignment_complete()

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11099


Change subject: cosmetic: drop param from send_assignment_complete()
......................................................................

cosmetic: drop param from send_assignment_complete()

After previous patch I8dd561d744d8081b5ac5ffa7635f17ac19bcda45, all callers
pass conn->lchan to send_assignment_complete(), so there is no need to pass it
separately from conn.

Change-Id: I3c038d91a53c81d9fcf4ec62f853b59bb1ecd244
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/11099/1

diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index a7564e0..2410adb 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -129,7 +129,7 @@
 	}
 }
 
-static void send_assignment_complete(struct gsm_subscriber_connection *conn, struct gsm_lchan *new_lchan)
+static void send_assignment_complete(struct gsm_subscriber_connection *conn)
 {
 	int rc;
 	struct gsm0808_speech_codec sc;
@@ -139,7 +139,7 @@
 	int perm_spch = 0;
 	uint8_t chosen_channel;
 	struct msgb *resp;
-	struct gsm_lchan *lchan = new_lchan;
+	struct gsm_lchan *lchan = conn->lchan;
 	struct osmo_fsm_inst *fi = conn->fi;
 
 	chosen_channel = gsm0808_chosen_channel(lchan->type, lchan->tch_mode);
@@ -207,7 +207,7 @@
 	/* apply LCLS configuration (if any) */
 	lcls_apply_config(conn);
 
-	send_assignment_complete(conn, conn->lchan);
+	send_assignment_complete(conn);
 	/* If something went wrong during send_assignment_complete(), the fi will be gone from
 	 * error handling in there. Almost a success, but then again the whole thing failed. */
 	if (!conn->assignment.fi) {
@@ -348,7 +348,7 @@
 				       " requested chan_mode=%s; current lchan is %s\n",
 				       gsm48_chan_mode_name(req->chan_mode),
 				       gsm_lchan_name(conn->lchan));
-			send_assignment_complete(conn, conn->lchan);
+			send_assignment_complete(conn);
 			return;
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/11099
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c038d91a53c81d9fcf4ec62f853b59bb1ecd244
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180926/9a4ede4b/attachment.htm>