<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11099">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: drop param from send_assignment_complete()<br><br>After previous patch I8dd561d744d8081b5ac5ffa7635f17ac19bcda45, all callers<br>pass conn->lchan to send_assignment_complete(), so there is no need to pass it<br>separately from conn.<br><br>Change-Id: I3c038d91a53c81d9fcf4ec62f853b59bb1ecd244<br>---<br>M src/osmo-bsc/assignment_fsm.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/11099/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c</span><br><span>index a7564e0..2410adb 100644</span><br><span>--- a/src/osmo-bsc/assignment_fsm.c</span><br><span>+++ b/src/osmo-bsc/assignment_fsm.c</span><br><span>@@ -129,7 +129,7 @@</span><br><span>     }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void send_assignment_complete(struct gsm_subscriber_connection *conn, struct gsm_lchan *new_lchan)</span><br><span style="color: hsl(120, 100%, 40%);">+static void send_assignment_complete(struct gsm_subscriber_connection *conn)</span><br><span> {</span><br><span>       int rc;</span><br><span>      struct gsm0808_speech_codec sc;</span><br><span>@@ -139,7 +139,7 @@</span><br><span>        int perm_spch = 0;</span><br><span>   uint8_t chosen_channel;</span><br><span>      struct msgb *resp;</span><br><span style="color: hsl(0, 100%, 40%);">-      struct gsm_lchan *lchan = new_lchan;</span><br><span style="color: hsl(120, 100%, 40%);">+  struct gsm_lchan *lchan = conn->lchan;</span><br><span>    struct osmo_fsm_inst *fi = conn->fi;</span><br><span> </span><br><span>  chosen_channel = gsm0808_chosen_channel(lchan->type, lchan->tch_mode);</span><br><span>@@ -207,7 +207,7 @@</span><br><span>   /* apply LCLS configuration (if any) */</span><br><span>      lcls_apply_config(conn);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    send_assignment_complete(conn, conn->lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+       send_assignment_complete(conn);</span><br><span>      /* If something went wrong during send_assignment_complete(), the fi will be gone from</span><br><span>        * error handling in there. Almost a success, but then again the whole thing failed. */</span><br><span>      if (!conn->assignment.fi) {</span><br><span>@@ -348,7 +348,7 @@</span><br><span>                                        " requested chan_mode=%s; current lchan is %s\n",</span><br><span>                                  gsm48_chan_mode_name(req->chan_mode),</span><br><span>                                     gsm_lchan_name(conn->lchan));</span><br><span style="color: hsl(0, 100%, 40%);">-                 send_assignment_complete(conn, conn->lchan);</span><br><span style="color: hsl(120, 100%, 40%);">+                       send_assignment_complete(conn);</span><br><span>                      return;</span><br><span>              }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11099">change 11099</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11099"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3c038d91a53c81d9fcf4ec62f853b59bb1ecd244 </div>
<div style="display:none"> Gerrit-Change-Number: 11099 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>