Change in docker-playground[master]: debian-repo-install-test: new binary package test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Sep 17 21:16:05 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10862 )

Change subject: debian-repo-install-test: new binary package test
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

Looks good to me.

I'm curious: how can we verify that this script catches errors? Should we create one or more "broken" feeds to make sure this script marks failure on them?

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh
File debian-repo-install-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh@14
PS6, Line 14: 		--entrypoint "/testdata/repo-install-test.sh" \
interesting, --entrypoint; so far in the other jenkins.sh we place the command to run as last argument. Is there any difference?


https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh
File debian-repo-install-test/testdata/repo-install-test.sh:

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh@42
PS6, Line 42: 	comm -23 /data/osmocom_packages_all.txt \
nice, a 23 on line 42!

I was going to say: nice, 'comm', hadn't heard of it yet!



-- 
To view, visit https://gerrit.osmocom.org/10862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007
Gerrit-Change-Number: 10862
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Sep 2018 21:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180917/fb2a88db/attachment.htm>


More information about the gerrit-log mailing list