<p style="white-space: pre-wrap; word-wrap: break-word;">Looks good to me.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm curious: how can we verify that this script catches errors? Should we create one or more "broken" feeds to make sure this script marks failure on them?</p><p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://gerrit.osmocom.org/10862">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh">File debian-repo-install-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh@14">Patch Set #6, Line 14:</a> <code style="font-family:monospace,monospace">         --entrypoint "/testdata/repo-install-test.sh" \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">interesting, --entrypoint; so far in the other jenkins.sh we place the command to run as last argument. Is there any difference?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh">File debian-repo-install-test/testdata/repo-install-test.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh@42">Patch Set #6, Line 42:</a> <code style="font-family:monospace,monospace"> comm -23 /data/osmocom_packages_all.txt \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">nice, a 23 on line 42!</p><p style="white-space: pre-wrap; word-wrap: break-word;">I was going to say: nice, 'comm', hadn't heard of it yet!</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/10862">change 10862</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10862"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007 </div>
<div style="display:none"> Gerrit-Change-Number: 10862 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 17 Sep 2018 21:16:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>