This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/10907 Change subject: gsm_data: remove unused struct member chan_mode ...................................................................... gsm_data: remove unused struct member chan_mode The struct member chan_mode in struct gsm_subscriber_connection is no longer used. There is only one VTY command that displays it along other parameters, but it is used no where else. Lets remove it. Change-Id: I10049c14ea206a4daafbdad01634d57c72a79d7c --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_vty.c 2 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/10907/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 5a922d1..33a5a8d 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -268,10 +268,6 @@ /* The connection identifier of the mgw_endpoint used to transceive RTP towards the MSC. * (The BTS side CI is handled by struct gsm_lchan and the lchan_fsm.) */ struct mgwep_ci *mgw_endpoint_ci_msc; - - /* Channel mode requested by the MSC (signalling or voice channel) */ - enum gsm48_chan_mode chan_mode; - } user_plane; /* LCLS (local call, local switch) related state */ diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index b1938e6..d06ec57 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -1472,9 +1472,8 @@ static void dump_one_subscr_conn(struct vty *vty, const struct gsm_subscriber_connection *conn) { - vty_out(vty, "conn ID=%u, MSC=%u, hodec2_fail=%d, mode=%s, mgw_ep=%s%s", + vty_out(vty, "conn ID=%u, MSC=%u, hodec2_fail=%d, mgw_ep=%s%s", conn->sccp.conn_id, conn->sccp.msc->nr, conn->hodec2.failures, - get_value_string(gsm48_chan_mode_names, conn->user_plane.chan_mode), mgw_endpoint_name(conn->user_plane.mgw_endpoint), VTY_NEWLINE); if (conn->lcls.global_call_ref_len) { vty_out(vty, " LCLS GCR: %s%s", -- To view, visit https://gerrit.osmocom.org/10907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I10049c14ea206a4daafbdad01634d57c72a79d7c Gerrit-Change-Number: 10907 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180912/56eaa4ed/attachment.htm>