<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10907">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_data: remove unused struct member chan_mode<br><br>The struct member chan_mode in struct gsm_subscriber_connection is no<br>longer used. There is only one VTY command that displays it along other<br>parameters, but it is used no where else. Lets remove it.<br><br>Change-Id: I10049c14ea206a4daafbdad01634d57c72a79d7c<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/bsc_vty.c<br>2 files changed, 1 insertion(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/10907/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 5a922d1..33a5a8d 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -268,10 +268,6 @@</span><br><span>              /* The connection identifier of the mgw_endpoint used to transceive RTP towards the MSC.</span><br><span>              * (The BTS side CI is handled by struct gsm_lchan and the lchan_fsm.) */</span><br><span>            struct mgwep_ci *mgw_endpoint_ci_msc;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-           /* Channel mode requested by the MSC (signalling or voice channel) */</span><br><span style="color: hsl(0, 100%, 40%);">-           enum gsm48_chan_mode chan_mode;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      } user_plane;</span><br><span> </span><br><span>    /* LCLS (local call, local switch) related state */</span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index b1938e6..d06ec57 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -1472,9 +1472,8 @@</span><br><span> </span><br><span> static void dump_one_subscr_conn(struct vty *vty, const struct gsm_subscriber_connection *conn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    vty_out(vty, "conn ID=%u, MSC=%u, hodec2_fail=%d, mode=%s, mgw_ep=%s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+    vty_out(vty, "conn ID=%u, MSC=%u, hodec2_fail=%d, mgw_ep=%s%s",</span><br><span>            conn->sccp.conn_id, conn->sccp.msc->nr, conn->hodec2.failures,</span><br><span style="color: hsl(0, 100%, 40%);">-              get_value_string(gsm48_chan_mode_names, conn->user_plane.chan_mode),</span><br><span>              mgw_endpoint_name(conn->user_plane.mgw_endpoint), VTY_NEWLINE);</span><br><span>   if (conn->lcls.global_call_ref_len) {</span><br><span>             vty_out(vty, " LCLS GCR: %s%s",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10907">change 10907</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10907"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I10049c14ea206a4daafbdad01634d57c72a79d7c </div>
<div style="display:none"> Gerrit-Change-Number: 10907 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>