Change in osmo-bts[master]: CBCH: Add FIXME comments on queue overflow/underflow handling

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10847


Change subject: CBCH: Add FIXME comments on queue overflow/underflow handling
......................................................................

CBCH: Add FIXME comments on queue overflow/underflow handling

Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
---
M src/common/cbch.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/10847/1

diff --git a/src/common/cbch.c b/src/common/cbch.c
index 56d76f1..7bbe2c9 100644
--- a/src/common/cbch.c
+++ b/src/common/cbch.c
@@ -136,6 +136,7 @@
 	}
 
 	llist_add_tail(&scm->list, &bts->smscb_state.queue);
+	/* FIXME: limit queue size and optionally send CBCH LOAD Information (overflow) via RSL */
 
 	return 0;
 }
@@ -145,8 +146,10 @@
 	struct smscb_msg *msg;
 
 	msg = llist_first_entry_or_null(&bts->smscb_state.queue, struct smscb_msg, list);
-	if (!msg)
+	if (!msg) {
+		/* FIXME: send CBCH LOAD Information (underflow) via RSL */
 		return NULL;
+	}
 
 	llist_del(&msg->list);
 

-- 
To view, visit https://gerrit.osmocom.org/10847
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40
Gerrit-Change-Number: 10847
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180909/76efb8f9/attachment.htm>