<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10847">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">CBCH: Add FIXME comments on queue overflow/underflow handling<br><br>Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40<br>---<br>M src/common/cbch.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/10847/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/cbch.c b/src/common/cbch.c</span><br><span>index 56d76f1..7bbe2c9 100644</span><br><span>--- a/src/common/cbch.c</span><br><span>+++ b/src/common/cbch.c</span><br><span>@@ -136,6 +136,7 @@</span><br><span>    }</span><br><span> </span><br><span>        llist_add_tail(&scm->list, &bts->smscb_state.queue);</span><br><span style="color: hsl(120, 100%, 40%);">+    /* FIXME: limit queue size and optionally send CBCH LOAD Information (overflow) via RSL */</span><br><span> </span><br><span>       return 0;</span><br><span> }</span><br><span>@@ -145,8 +146,10 @@</span><br><span>        struct smscb_msg *msg;</span><br><span> </span><br><span>   msg = llist_first_entry_or_null(&bts->smscb_state.queue, struct smscb_msg, list);</span><br><span style="color: hsl(0, 100%, 40%);">-        if (!msg)</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!msg) {</span><br><span style="color: hsl(120, 100%, 40%);">+           /* FIXME: send CBCH LOAD Information (underflow) via RSL */</span><br><span>          return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        llist_del(&msg->list);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10847">change 10847</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10847"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40 </div>
<div style="display:none"> Gerrit-Change-Number: 10847 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>