Change in osmocom-bb[master]: trx_toolkit/fake_trx: drop Timing Advance range limitation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 7 09:02:20 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10818 )

Change subject: trx_toolkit/fake_trx: drop Timing Advance range limitation
......................................................................

trx_toolkit/fake_trx: drop Timing Advance range limitation

Despite the correct range of Timing Advance value is [0..63],
there is a special feature in OsmocomBB which allows one to
simulate the distance between both MS and a BTS by playing
with the signal delay.

So, let's drop the range limitation.

Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7
---
M src/target/trx_toolkit/ctrl_if_bb.py
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/target/trx_toolkit/ctrl_if_bb.py b/src/target/trx_toolkit/ctrl_if_bb.py
index 929caf4..808c880 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -119,12 +119,6 @@
 		elif self.verify_cmd(request, "SETTA", 1):
 			print("[i] Recv SETTA cmd")
 
-			# Parse and check TA value
-			ta = int(request[1])
-			if ta < 0 or ta > 63:
-				print("[!] TA value should be in range: 0..63")
-				return -1
-
 			# Save to the BurstForwarder instance
 			self.burst_fwd.ta = ta
 			return 0

-- 
To view, visit https://gerrit.osmocom.org/10818
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7
Gerrit-Change-Number: 10818
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180907/6007f05e/attachment.htm>


More information about the gerrit-log mailing list