<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10818">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/fake_trx: drop Timing Advance range limitation<br><br>Despite the correct range of Timing Advance value is [0..63],<br>there is a special feature in OsmocomBB which allows one to<br>simulate the distance between both MS and a BTS by playing<br>with the signal delay.<br><br>So, let's drop the range limitation.<br><br>Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7<br>---<br>M src/target/trx_toolkit/ctrl_if_bb.py<br>1 file changed, 0 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/ctrl_if_bb.py b/src/target/trx_toolkit/ctrl_if_bb.py</span><br><span>index 929caf4..808c880 100644</span><br><span>--- a/src/target/trx_toolkit/ctrl_if_bb.py</span><br><span>+++ b/src/target/trx_toolkit/ctrl_if_bb.py</span><br><span>@@ -119,12 +119,6 @@</span><br><span>          elif self.verify_cmd(request, "SETTA", 1):</span><br><span>                         print("[i] Recv SETTA cmd")</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                       # Parse and check TA value</span><br><span style="color: hsl(0, 100%, 40%);">-                      ta = int(request[1])</span><br><span style="color: hsl(0, 100%, 40%);">-                    if ta < 0 or ta > 63:</span><br><span style="color: hsl(0, 100%, 40%);">-                             print("[!] TA value should be in range: 0..63")</span><br><span style="color: hsl(0, 100%, 40%);">-                               return -1</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>                    # Save to the BurstForwarder instance</span><br><span>                        self.burst_fwd.ta = ta</span><br><span>                       return 0</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10818">change 10818</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10818"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I8fd2a2ab7784b38bde5ebcfd0359b7e2cb53f5a7 </div>
<div style="display:none"> Gerrit-Change-Number: 10818 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>