This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/10747 ) Change subject: mgcp_client_test: use "\r\n\r\n" instead of "\n\n" ...................................................................... mgcp_client_test: use "\r\n\r\n" instead of "\n\n" The separator between MGCP and SDP section is typically "\r\n\r\n". For some reason the test so far used "\n\n" instead, rather use the standard separator. Change-Id: I41c73722e5fae00663bcf96de0b57b7155809a06 --- M tests/mgcp_client/mgcp_client_test.c M tests/mgcp_client/mgcp_client_test.ok 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/tests/mgcp_client/mgcp_client_test.c b/tests/mgcp_client/mgcp_client_test.c index 84ba3b4..4e7e0a7 100644 --- a/tests/mgcp_client/mgcp_client_test.c +++ b/tests/mgcp_client/mgcp_client_test.c @@ -149,7 +149,7 @@ trans_id = dummy_mgcp_send(msg); reply_to(trans_id, 200, "OK", - "I: 1\n\n" + "I: 1\r\n\r\n" "v=0\r\n" "o=- 1 23 IN IP4 10.9.1.120\r\n" "s=-\r\n" @@ -336,7 +336,7 @@ OSMO_ASSERT(mgcp_client_cancel(mgcp, trans_id) == 0); fprintf(stderr, "- late response gets discarded\n"); - OSMO_ASSERT(reply_to(trans_id, 200, "OK", "I: 1\n\nv=0\r\n") == -ENOENT); + OSMO_ASSERT(reply_to(trans_id, 200, "OK", "I: 1\r\n\r\nv=0\r\n") == -ENOENT); fprintf(stderr, "- canceling again does nothing\n"); OSMO_ASSERT(mgcp_client_cancel(mgcp, trans_id) == -ENOENT); diff --git a/tests/mgcp_client/mgcp_client_test.ok b/tests/mgcp_client/mgcp_client_test.ok index 58c4b82..4b1e78c 100644 --- a/tests/mgcp_client/mgcp_client_test.ok +++ b/tests/mgcp_client/mgcp_client_test.ok @@ -11,8 +11,8 @@ composed response: ----- 200 1 OK -I: 1 - +I: 1 + v=0 o=- 1 23 IN IP4 10.9.1.120 s=- @@ -141,8 +141,8 @@ composed response: ----- 200 1 OK -I: 1 - +I: 1 + v=0 ----- -- To view, visit https://gerrit.osmocom.org/10747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41c73722e5fae00663bcf96de0b57b7155809a06 Gerrit-Change-Number: 10747 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/8021f449/attachment.htm>