<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/10747">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp_client_test: use "\r\n\r\n" instead of "\n\n"<br><br>The separator between MGCP and SDP section is typically "\r\n\r\n". For some<br>reason the test so far used "\n\n" instead, rather use the standard separator.<br><br>Change-Id: I41c73722e5fae00663bcf96de0b57b7155809a06<br>---<br>M tests/mgcp_client/mgcp_client_test.c<br>M tests/mgcp_client/mgcp_client_test.ok<br>2 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/mgcp_client/mgcp_client_test.c b/tests/mgcp_client/mgcp_client_test.c</span><br><span>index 84ba3b4..4e7e0a7 100644</span><br><span>--- a/tests/mgcp_client/mgcp_client_test.c</span><br><span>+++ b/tests/mgcp_client/mgcp_client_test.c</span><br><span>@@ -149,7 +149,7 @@</span><br><span>       trans_id = dummy_mgcp_send(msg);</span><br><span> </span><br><span>         reply_to(trans_id, 200, "OK",</span><br><span style="color: hsl(0, 100%, 40%);">-         "I: 1\n\n"</span><br><span style="color: hsl(120, 100%, 40%);">+          "I: 1\r\n\r\n"</span><br><span>             "v=0\r\n"</span><br><span>          "o=- 1 23 IN IP4 10.9.1.120\r\n"</span><br><span>           "s=-\r\n"</span><br><span>@@ -336,7 +336,7 @@</span><br><span>    OSMO_ASSERT(mgcp_client_cancel(mgcp, trans_id) == 0);</span><br><span> </span><br><span>    fprintf(stderr, "- late response gets discarded\n");</span><br><span style="color: hsl(0, 100%, 40%);">-  OSMO_ASSERT(reply_to(trans_id, 200, "OK", "I: 1\n\nv=0\r\n") == -ENOENT);</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(reply_to(trans_id, 200, "OK", "I: 1\r\n\r\nv=0\r\n") == -ENOENT);</span><br><span> </span><br><span>        fprintf(stderr, "- canceling again does nothing\n");</span><br><span>       OSMO_ASSERT(mgcp_client_cancel(mgcp, trans_id) == -ENOENT);</span><br><span>diff --git a/tests/mgcp_client/mgcp_client_test.ok b/tests/mgcp_client/mgcp_client_test.ok</span><br><span>index 58c4b82..4b1e78c 100644</span><br><span>--- a/tests/mgcp_client/mgcp_client_test.ok</span><br><span>+++ b/tests/mgcp_client/mgcp_client_test.ok</span><br><span>@@ -11,8 +11,8 @@</span><br><span> composed response:</span><br><span> -----</span><br><span> 200 1 OK </span><br><span style="color: hsl(0, 100%, 40%);">-I: 1</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+I: 1 </span><br><span style="color: hsl(120, 100%, 40%);">+ </span><br><span> v=0 </span><br><span> o=- 1 23 IN IP4 10.9.1.120 </span><br><span> s=- </span><br><span>@@ -141,8 +141,8 @@</span><br><span> composed response:</span><br><span> -----</span><br><span> 200 1 OK </span><br><span style="color: hsl(0, 100%, 40%);">-I: 1</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+I: 1 </span><br><span style="color: hsl(120, 100%, 40%);">+ </span><br><span> v=0 </span><br><span> </span><br><span> -----</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10747">change 10747</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10747"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I41c73722e5fae00663bcf96de0b57b7155809a06 </div>
<div style="display:none"> Gerrit-Change-Number: 10747 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>