This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10671 ) Change subject: stdio: fix detection of malformated format strings ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10671/1/firmware/libcommon/source/stdio.c File firmware/libcommon/source/stdio.c: https://gerrit.osmocom.org/#/c/10671/1/firmware/libcommon/source/stdio.c@407 PS1, Line 407: va_end(ap); yes, should va_end() before evaluating rc. Then again, you're just returning rc in both cases, so why even have this "if"? IIUC this patch doesn't change a thing about anything. Do you mean to preserve errno or something?? -- To view, visit https://gerrit.osmocom.org/10671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8506b05d56da55d1357a1234917adf341b46e1db Gerrit-Change-Number: 10671 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Sat, 01 Sep 2018 21:56:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180901/04936f84/attachment.htm>