<p><a href="https://gerrit.osmocom.org/10671">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10671/1/firmware/libcommon/source/stdio.c">File firmware/libcommon/source/stdio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10671/1/firmware/libcommon/source/stdio.c@407">Patch Set #1, Line 407:</a> <code style="font-family:monospace,monospace">        va_end(ap);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">yes, should va_end() before evaluating rc. Then again, you're just returning rc in both cases, so why even have this "if"? IIUC this patch doesn't change a thing about anything. Do you mean to preserve errno or something??</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/10671">change 10671</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10671"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8506b05d56da55d1357a1234917adf341b46e1db </div>
<div style="display:none"> Gerrit-Change-Number: 10671 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-CC: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 01 Sep 2018 21:56:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>