Change in osmo-bsc[master]: handover_fsm: fix failure logging of uninitialized chan mode

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11512 )

Change subject: handover_fsm: fix failure logging of uninitialized chan mode
......................................................................

handover_fsm: fix failure logging of uninitialized chan mode

The chan mode is figured out per-BTS, but may remain uninitialized. Rather log
info about the channel request, like further above.

Change-Id: I07b89b6101879fb7c070c87be9bd38cc05ffa0b1
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index a45e33b..0107ef0 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -592,9 +592,8 @@
 	}
 
 	if (!ho->new_lchan) {
-		ho_fail(HO_RESULT_ERROR, "No free/matching lchan found for %s %s %s\n",
-			req->cell_id_target_name,
-			gsm48_chan_mode_name(mode), full_rate ? "full-rate" : "half-rate");
+		ho_fail(HO_RESULT_ERROR, "No free/matching lchan found for %s %s (speech codec list len = %u)",
+			req->cell_id_target_name, gsm0808_channel_type_name(&req->ct), req->scl.len);
 		return;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/11512
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07b89b6101879fb7c070c87be9bd38cc05ffa0b1
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181029/12bbeebf/attachment.htm>