<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11512">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">handover_fsm: fix failure logging of uninitialized chan mode<br><br>The chan mode is figured out per-BTS, but may remain uninitialized. Rather log<br>info about the channel request, like further above.<br><br>Change-Id: I07b89b6101879fb7c070c87be9bd38cc05ffa0b1<br>---<br>M src/osmo-bsc/handover_fsm.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index a45e33b..0107ef0 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -592,9 +592,8 @@</span><br><span>     }</span><br><span> </span><br><span>        if (!ho->new_lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                ho_fail(HO_RESULT_ERROR, "No free/matching lchan found for %s %s %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                       req->cell_id_target_name,</span><br><span style="color: hsl(0, 100%, 40%);">-                    gsm48_chan_mode_name(mode), full_rate ? "full-rate" : "half-rate");</span><br><span style="color: hsl(120, 100%, 40%);">+               ho_fail(HO_RESULT_ERROR, "No free/matching lchan found for %s %s (speech codec list len = %u)",</span><br><span style="color: hsl(120, 100%, 40%);">+                     req->cell_id_target_name, gsm0808_channel_type_name(&req->ct), req->scl.len);</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11512">change 11512</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11512"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I07b89b6101879fb7c070c87be9bd38cc05ffa0b1 </div>
<div style="display:none"> Gerrit-Change-Number: 11512 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>