Change in osmo-bsc[master]: osmo_bsc_msc: Set reasonable codec list defaults

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 5 09:36:37 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11237 )

Change subject: osmo_bsc_msc: Set reasonable codec list defaults
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11237/1/src/osmo-bsc/osmo_bsc_msc.c
File src/osmo-bsc/osmo_bsc_msc.c:

https://gerrit.osmocom.org/#/c/11237/1/src/osmo-bsc/osmo_bsc_msc.c@97
PS1, Line 97: Set GSM-FR as default for the codec list
Why not enable all codecs by default? I think that's the "most compatible", isn't it?  The MSC can request any subset of that in the ASSIGNMENT CMD.

What advantage does restricting it to FR1 have?


https://gerrit.osmocom.org/#/c/11237/1/src/osmo-bsc/osmo_bsc_msc.c@100
PS1, Line 100: 	msc_data->audio_support[0] = talloc_zero(msc_data->audio_support, struct gsm_audio_support);	
whitespace problems



-- 
To view, visit https://gerrit.osmocom.org/11237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3749a65828c788f38c22f0a5314533f4516da3ed
Gerrit-Change-Number: 11237
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 05 Oct 2018 09:36:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/b7208541/attachment.htm>


More information about the gerrit-log mailing list