Change in osmo-bsc[master]: osmo_bsc_msc: Set reasonable codec list defaults

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Oct 5 08:41:28 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11237


Change subject: osmo_bsc_msc: Set reasonable codec list defaults
......................................................................

osmo_bsc_msc: Set reasonable codec list defaults

When the user sets no codec-list in the msc node, the configuration will
end up with an empty codec list. This is a useless configuration. There
should be a sane default setting.

- Set fr1 as default for codec-list as it is the smallest possible
  denominator.

Change-Id: I3749a65828c788f38c22f0a5314533f4516da3ed
Related: OS#3625
---
M src/osmo-bsc/osmo_bsc_msc.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/11237/1

diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index e00c9ef..03951d2 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -94,6 +94,12 @@
 	/* Defaults for the audio setup */
 	msc_data->amr_conf.m5_90 = 1;
 
+	/* Set GSM-FR as default for the codec list */
+	msc_data->audio_support = talloc_zero_array(msc_data, struct gsm_audio_support*, 1);
+	msc_data->audio_length = 1;
+	msc_data->audio_support[0] = talloc_zero(msc_data->audio_support, struct gsm_audio_support);	
+	msc_data->audio_support[0]->ver = 1;
+		
 	return msc_data;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/11237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3749a65828c788f38c22f0a5314533f4516da3ed
Gerrit-Change-Number: 11237
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/c84cedc4/attachment.htm>


More information about the gerrit-log mailing list