This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11201 )
Change subject: pySim-prog: Honor international '+' in SMSC number
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py
File pySim-prog.py:
https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@100
PS1, Line 100: help="SMSP [default: '00 + country code + 5555']",
"If it starts with a '+', Type-of-Number is programmed as 'international'" ?
... is "SMSP" correct?
https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@329
PS1, Line 329: raise ValueError('SMSC must be digits only !')
"and optionally start with a '+'" ?
--
To view, visit https://gerrit.osmocom.org/11201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia79913f5b0307e9786a5acea75c0811927be2eef
Gerrit-Change-Number: 11201
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Oct 2018 18:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181002/468ceb6a/attachment.htm>