Change in pysim[master]: pySim-prog: Honor international '+' in SMSC number

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Oct 2 17:59:23 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11201 )

Change subject: pySim-prog: Honor international '+' in SMSC number
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py
File pySim-prog.py:

https://gerrit.osmocom.org/#/c/11201/1/pySim-prog.py@325
PS1, Line 325:                         if smsc[0] == '+':
cosmetic: the rest of the file is indented by tabs, the new lines by spaces



-- 
To view, visit https://gerrit.osmocom.org/11201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia79913f5b0307e9786a5acea75c0811927be2eef
Gerrit-Change-Number: 11201
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Oct 2018 17:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181002/89ef22e4/attachment.htm>


More information about the gerrit-log mailing list