Change in osmo-bsc[master]: bsc: lchan_select: Avoid returning a TCH/H lchan when TCH/F is requested

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11987


Change subject: bsc: lchan_select: Avoid returning a TCH/H lchan when TCH/F is requested
......................................................................

bsc: lchan_select: Avoid returning a TCH/H lchan when TCH/F is requested

If BTS is configured to have only TCH/F_PDCH and TCH/H and a call is
resolved to require TCH/F, don't return the TCH/H which have no use, but
instead let it allocate the TCH/F_PDCH.

Change-Id: I9a73beb0432fab16d5430e5b40d470694e09b189
---
M src/osmo-bsc/lchan_select.c
1 file changed, 1 insertion(+), 16 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/11987/1

diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c
index 742c7de..f70ad4a 100644
--- a/src/osmo-bsc/lchan_select.c
+++ b/src/osmo-bsc/lchan_select.c
@@ -182,13 +182,7 @@
 		break;
 	case GSM_LCHAN_TCH_F:
 		lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_F);
-		/* If we don't have TCH/F available, fall-back to TCH/H */
-		if (!lchan) {
-			lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H);
-			if (lchan)
-				type = GSM_LCHAN_TCH_H;
-		}
-		/* If we don't have TCH/H either, try dynamic TCH/F_PDCH */
+		/* If we don't have TCH/F available, try dynamic TCH/F_PDCH */
 		if (!lchan) {
 			lchan = _lc_dyn_find_bts(bts, GSM_PCHAN_TCH_F_PDCH,
 						 GSM_PCHAN_TCH_F);
@@ -206,14 +200,6 @@
 			if (lchan)
 				type = GSM_LCHAN_TCH_F;
 		}
-		/* ...and as TCH/H. */
-		if (!lchan) {
-			lchan = _lc_dyn_find_bts(bts,
-						 GSM_PCHAN_TCH_F_TCH_H_PDCH,
-						 GSM_PCHAN_TCH_H);
-			if (lchan)
-				type = GSM_LCHAN_TCH_H;
-		}
 		break;
 	case GSM_LCHAN_TCH_H:
 		lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H);
@@ -257,4 +243,3 @@
 
 	return lchan;
 }
-

-- 
To view, visit https://gerrit.osmocom.org/11987
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a73beb0432fab16d5430e5b40d470694e09b189
Gerrit-Change-Number: 11987
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181128/c9a6687d/attachment.htm>