<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11987">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: lchan_select: Avoid returning a TCH/H lchan when TCH/F is requested<br><br>If BTS is configured to have only TCH/F_PDCH and TCH/H and a call is<br>resolved to require TCH/F, don't return the TCH/H which have no use, but<br>instead let it allocate the TCH/F_PDCH.<br><br>Change-Id: I9a73beb0432fab16d5430e5b40d470694e09b189<br>---<br>M src/osmo-bsc/lchan_select.c<br>1 file changed, 1 insertion(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/11987/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c</span><br><span>index 742c7de..f70ad4a 100644</span><br><span>--- a/src/osmo-bsc/lchan_select.c</span><br><span>+++ b/src/osmo-bsc/lchan_select.c</span><br><span>@@ -182,13 +182,7 @@</span><br><span>          break;</span><br><span>       case GSM_LCHAN_TCH_F:</span><br><span>                lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_F);</span><br><span style="color: hsl(0, 100%, 40%);">-             /* If we don't have TCH/F available, fall-back to TCH/H */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H);</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_H;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-               /* If we don't have TCH/H either, try dynamic TCH/F_PDCH */</span><br><span style="color: hsl(120, 100%, 40%);">+               /* If we don't have TCH/F available, try dynamic TCH/F_PDCH */</span><br><span>           if (!lchan) {</span><br><span>                        lchan = _lc_dyn_find_bts(bts, GSM_PCHAN_TCH_F_PDCH,</span><br><span>                                           GSM_PCHAN_TCH_F);</span><br><span>@@ -206,14 +200,6 @@</span><br><span>                    if (lchan)</span><br><span>                           type = GSM_LCHAN_TCH_F;</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               /* ...and as TCH/H. */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (!lchan) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   lchan = _lc_dyn_find_bts(bts,</span><br><span style="color: hsl(0, 100%, 40%);">-                                            GSM_PCHAN_TCH_F_TCH_H_PDCH,</span><br><span style="color: hsl(0, 100%, 40%);">-                                             GSM_PCHAN_TCH_H);</span><br><span style="color: hsl(0, 100%, 40%);">-                      if (lchan)</span><br><span style="color: hsl(0, 100%, 40%);">-                              type = GSM_LCHAN_TCH_H;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span>            break;</span><br><span>       case GSM_LCHAN_TCH_H:</span><br><span>                lchan = _lc_find_bts(bts, GSM_PCHAN_TCH_H);</span><br><span>@@ -257,4 +243,3 @@</span><br><span> </span><br><span>        return lchan;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11987">change 11987</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11987"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9a73beb0432fab16d5430e5b40d470694e09b189 </div>
<div style="display:none"> Gerrit-Change-Number: 11987 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>