This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/11899 Change subject: sms_sueue: count GSM_PAGING_BUSY and GSM_PAGING_EXPIRED ...................................................................... sms_sueue: count GSM_PAGING_BUSY and GSM_PAGING_EXPIRED When sms delivery fails normally db_sms_inc_deliver_attempts() is executed to increase a counter in the database. Once the counter reaches a maxium (10 by default) the SM queue gives up on doing further delivery attempts. For some reason GSM_PAGING_EXPIRED and GSM_PAGING_BUSY are not taken into account by the mechanism, which causes an infinite number of SMS delivery attempts. - Count GSM_PAGING_BUSY as failed delivery attempt - Count GSM_PAGING_EXPIRED as failed delivery ttempt Change-Id: I88a51568b43a1414e72ce74d7ba2e9406cf07f9f Related: OS#3704 --- M src/libmsc/sms_queue.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/11899/1 diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c index 252e529..d7ba41a 100644 --- a/src/libmsc/sms_queue.c +++ b/src/libmsc/sms_queue.c @@ -509,9 +509,11 @@ sms_pending_failed(pending, 0); break; case GSM_PAGING_EXPIRED: + db_sms_inc_deliver_attempts(sig_sms->sms); sms_pending_failed(pending, 1); break; case GSM_PAGING_BUSY: + db_sms_inc_deliver_attempts(sig_sms->sms); network->sms_queue->pending -= 1; sms_pending_free(pending); sms_queue_trigger(network->sms_queue); -- To view, visit https://gerrit.osmocom.org/11899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I88a51568b43a1414e72ce74d7ba2e9406cf07f9f Gerrit-Change-Number: 11899 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/a50f4ec3/attachment.htm>