<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11899">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sms_sueue: count GSM_PAGING_BUSY and GSM_PAGING_EXPIRED<br><br>When sms delivery fails normally db_sms_inc_deliver_attempts() is<br>executed to increase a counter in the database. Once the counter reaches<br>a maxium (10 by default) the SM queue gives up on doing further delivery<br>attempts. For some reason GSM_PAGING_EXPIRED and GSM_PAGING_BUSY are not<br>taken into account by the mechanism, which causes an infinite number of<br>SMS delivery attempts.<br><br>- Count GSM_PAGING_BUSY as failed delivery attempt<br>- Count GSM_PAGING_EXPIRED as failed delivery ttempt<br><br>Change-Id: I88a51568b43a1414e72ce74d7ba2e9406cf07f9f<br>Related: OS#3704<br>---<br>M src/libmsc/sms_queue.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/11899/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c</span><br><span>index 252e529..d7ba41a 100644</span><br><span>--- a/src/libmsc/sms_queue.c</span><br><span>+++ b/src/libmsc/sms_queue.c</span><br><span>@@ -509,9 +509,11 @@</span><br><span>                   sms_pending_failed(pending, 0);</span><br><span>                      break;</span><br><span>               case GSM_PAGING_EXPIRED:</span><br><span style="color: hsl(120, 100%, 40%);">+                      db_sms_inc_deliver_attempts(sig_sms->sms);</span><br><span>                        sms_pending_failed(pending, 1);</span><br><span>                      break;</span><br><span>               case GSM_PAGING_BUSY:</span><br><span style="color: hsl(120, 100%, 40%);">+                 db_sms_inc_deliver_attempts(sig_sms->sms);</span><br><span>                        network->sms_queue->pending -= 1;</span><br><span>                      sms_pending_free(pending);</span><br><span>                   sms_queue_trigger(network->sms_queue);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11899">change 11899</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11899"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I88a51568b43a1414e72ce74d7ba2e9406cf07f9f </div>
<div style="display:none"> Gerrit-Change-Number: 11899 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>