Change in osmo-bsc[master]: make MSC Release (MSCR) configurable

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11884


Change subject: make MSC Release (MSCR) configurable
......................................................................

make MSC Release (MSCR) configurable

Add msc_release to the config to toggle the bit that indicates
R98/R99+ compatibility.

Related: OS#3697
Change-Id: I7c3c64c876e2d8e08291ca4be7bd3249979430cb
---
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/osmo_bsc_main.c
2 files changed, 15 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11884/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 4f18d47..f354f98 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -785,6 +785,7 @@
 	vty_out(vty, "  cell_identity %u%s", bts->cell_identity, VTY_NEWLINE);
 	vty_out(vty, "  location_area_code %u%s", bts->location_area_code,
 		VTY_NEWLINE);
+	vty_out(vty, "  msc_release %u%s", bts->si_common.chan_desc.mscr, VTY_NEWLINE);
 	if (bts->dtxu != GSM48_DTX_SHALL_NOT_BE_USED)
 		vty_out(vty, "  dtx uplink%s%s",
 			(bts->dtxu != GSM48_DTX_SHALL_BE_USED) ? "" : " force",
@@ -2089,6 +2090,19 @@
 }
 
 
+DEFUN(cfg_bts_mscr,
+      cfg_bts_mscr_cmd,
+      "msc_release (0|1)",
+      "Set the MSC Release (MSCR) of this BTS\n"
+      "Release '98 or older" "Release '99 onwards")
+{
+	struct gsm_bts *bts = vty->index;
+	bts->si_common.chan_desc.mscr = atoi(argv[0]);
+
+	return CMD_SUCCESS;
+}
+
+
 /* compatibility wrapper for old config files */
 DEFUN_HIDDEN(cfg_bts_tsc,
       cfg_bts_tsc_cmd,
@@ -4991,6 +5005,7 @@
 	install_element(BTS_NODE, &cfg_bts_no_dtxu_cmd);
 	install_element(BTS_NODE, &cfg_bts_no_dtxd_cmd);
 	install_element(BTS_NODE, &cfg_bts_lac_cmd);
+	install_element(BTS_NODE, &cfg_bts_mscr_cmd);
 	install_element(BTS_NODE, &cfg_bts_tsc_cmd);
 	install_element(BTS_NODE, &cfg_bts_bsic_cmd);
 	install_element(BTS_NODE, &cfg_bts_unit_id_cmd);
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 67fccd3..29f4327 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -444,9 +444,6 @@
 	for (n=0, i=0; i<8; i++)
 		n += bts->c0->ts[i].pchan_is == GSM_PCHAN_CCCH ? 1 : 0;
 
-	/* Indicate R99 MSC in SI3 */
-	bts->si_common.chan_desc.mscr = 1;
-
 	switch (n) {
 	case 0:
 		bts->si_common.chan_desc.ccch_conf = RSL_BCCH_CCCH_CONF_1_C;

-- 
To view, visit https://gerrit.osmocom.org/11884
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c3c64c876e2d8e08291ca4be7bd3249979430cb
Gerrit-Change-Number: 11884
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/ee57cf20/attachment.htm>