<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11884">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">make MSC Release (MSCR) configurable<br><br>Add msc_release to the config to toggle the bit that indicates<br>R98/R99+ compatibility.<br><br>Related: OS#3697<br>Change-Id: I7c3c64c876e2d8e08291ca4be7bd3249979430cb<br>---<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/osmo_bsc_main.c<br>2 files changed, 15 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/11884/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index 4f18d47..f354f98 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -785,6 +785,7 @@</span><br><span>  vty_out(vty, "  cell_identity %u%s", bts->cell_identity, VTY_NEWLINE);</span><br><span>  vty_out(vty, "  location_area_code %u%s", bts->location_area_code,</span><br><span>              VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, "  msc_release %u%s", bts->si_common.chan_desc.mscr, VTY_NEWLINE);</span><br><span>         if (bts->dtxu != GSM48_DTX_SHALL_NOT_BE_USED)</span><br><span>             vty_out(vty, "  dtx uplink%s%s",</span><br><span>                   (bts->dtxu != GSM48_DTX_SHALL_BE_USED) ? "" : " force",</span><br><span>@@ -2089,6 +2090,19 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_bts_mscr,</span><br><span style="color: hsl(120, 100%, 40%);">+      cfg_bts_mscr_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+      "msc_release (0|1)",</span><br><span style="color: hsl(120, 100%, 40%);">+      "Set the MSC Release (MSCR) of this BTS\n"</span><br><span style="color: hsl(120, 100%, 40%);">+      "Release '98 or older" "Release '99 onwards")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+      struct gsm_bts *bts = vty->index;</span><br><span style="color: hsl(120, 100%, 40%);">+  bts->si_common.chan_desc.mscr = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* compatibility wrapper for old config files */</span><br><span> DEFUN_HIDDEN(cfg_bts_tsc,</span><br><span>       cfg_bts_tsc_cmd,</span><br><span>@@ -4991,6 +5005,7 @@</span><br><span>        install_element(BTS_NODE, &cfg_bts_no_dtxu_cmd);</span><br><span>         install_element(BTS_NODE, &cfg_bts_no_dtxd_cmd);</span><br><span>         install_element(BTS_NODE, &cfg_bts_lac_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+      install_element(BTS_NODE, &cfg_bts_mscr_cmd);</span><br><span>    install_element(BTS_NODE, &cfg_bts_tsc_cmd);</span><br><span>     install_element(BTS_NODE, &cfg_bts_bsic_cmd);</span><br><span>    install_element(BTS_NODE, &cfg_bts_unit_id_cmd);</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>index 67fccd3..29f4327 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_main.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_main.c</span><br><span>@@ -444,9 +444,6 @@</span><br><span>      for (n=0, i=0; i<8; i++)</span><br><span>          n += bts->c0->ts[i].pchan_is == GSM_PCHAN_CCCH ? 1 : 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       /* Indicate R99 MSC in SI3 */</span><br><span style="color: hsl(0, 100%, 40%);">-   bts->si_common.chan_desc.mscr = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        switch (n) {</span><br><span>         case 0:</span><br><span>              bts->si_common.chan_desc.ccch_conf = RSL_BCCH_CCCH_CONF_1_C;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11884">change 11884</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11884"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7c3c64c876e2d8e08291ca4be7bd3249979430cb </div>
<div style="display:none"> Gerrit-Change-Number: 11884 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>