This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho ...................................................................... Patch Set 2: Code-Review+2 build fails with: ==== handover_fsm.c: In function 'send_handover_performed': handover_fsm.c:678:36: error: storage size of 'ho_perf_params' isn't known struct gsm0808_handover_performed ho_perf_params; ^ handover_fsm.c:718:2: error: implicit declaration of function 'gsm0808_create_handover_performed' [-Werror=implicit-function-declaration] msg = gsm0808_create_handover_performed(&ho_perf_params); ^ handover_fsm.c:678:36: error: unused variable 'ho_perf_params' [-Werror=unused-variable] struct gsm0808_handover_performed ho_perf_params; ^ cc1: all warnings being treated as errors ==== otherwise the patch looks good to me -- To view, visit https://gerrit.osmocom.org/11734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351 Gerrit-Change-Number: 11734 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 22 Nov 2018 12:55:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/9f64b591/attachment.htm>