<pre style="font-family: monospace,monospace; white-space: pre-wrap;">build fails with:<br>====<br>handover_fsm.c: In function 'send_handover_performed':<br>handover_fsm.c:678:36: error: storage size of 'ho_perf_params' isn't known<br>  struct gsm0808_handover_performed ho_perf_params;<br>                                    ^<br>handover_fsm.c:718:2: error: implicit declaration of function 'gsm0808_create_handover_performed' [-Werror=implicit-function-declaration]<br>  msg = gsm0808_create_handover_performed(&ho_perf_params);<br>  ^<br>handover_fsm.c:678:36: error: unused variable 'ho_perf_params' [-Werror=unused-variable]<br>  struct gsm0808_handover_performed ho_perf_params;<br>                                    ^<br>cc1: all warnings being treated as errors<br>====</pre><p style="white-space: pre-wrap; word-wrap: break-word;">otherwise the patch looks good to me</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://gerrit.osmocom.org/11734">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11734">change 11734</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11734"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351 </div>
<div style="display:none"> Gerrit-Change-Number: 11734 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 22 Nov 2018 12:55:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>