This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages ...................................................................... Patch Set 2: (9 comments) https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc File common/chapters/gsup.adoc: https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@507 PS2, Line 507: ==== MO-forwardSM Request > I'm slightly critical of the mix of dash and non-caps / CamelCase / acronym style. […] Well, this mix is not my invention. I am also not a big fun of such style. But exactly this form is used in the MAP specifications and Wireshark. Anyway, I will think about changing to "MO Forward Short Message Request". https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@509 PS2, Line 509: Direction: SGSN / MSC => ESME (through VLR and HLR) > I'm curious why you name the SGSN first. So far I wasn't aware of our SGSN even able to send SMS. It isn't able yet, but there should be an issue about that. I will change the order despite I don't think it's important. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@522 PS2, Line 522: This message is used to forward _MO (Mobile Originated)_ short messages Actually, there is some magic happening between "When a subscriber sends an SMS" and MSC / SGSN "forwards it to the ESME", so I could not just omit this part (SMC, SMR state machines) without a proper explanation. > Direction: SGSN / MSC => ESME (through VLR and HLR) This line clearly defines the scope - we are at the MSC / SGSN level, and we deal with MO/MT SMS messages. I don't think "MO/MT" is too technical to understand, moreover I believe everyone in the mobile telecom area should know what it means. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@524 PS2, Line 524: Entity). The corresponding MAP service (defined in 3GPP TS 29.002) is > We have a glossary of acronyms, maybe rather make sure they are in the glossary and abbreviate every […] Thanks, I'll check out the glossary of acronyms. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@525 PS2, Line 525: *MAP-MO-FORWARD-SHORT-MESSAGE*, described in section 12.2. > rather give the spec reference once, complete, in the end "... (see 3GPP TS 29.002 section 12. […] Thanks, I'll correct this part. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@528 PS2, Line 528: attempt and _RP-SMMA_ notification attempt on the _SM-RL (Relay Layer)_. > "attempt" sounds like it fails This word was taken exactly from the GSM 04.11 specs. Probably, I will change to "request", but I also don't think this is critical. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@532 PS2, Line 532: Direction: ESME (through VLR and HLR) => SGSN / MSC > above it spells "MSC => ESME (through VLR and HLR)" -- maybe rather reverse it here? "ESME (through […] No need to reverse, this is correct. - Request is sent from MSC / SGSN to ESME, - Result / Error is sent back from ESME. Message flows to be introduced later. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@545 PS2, Line 545: short message delivery from SGSN (PS domain) / MSC (CS domain) to an ESME > above it says ESME => MSC, in this sentence the direction is reversed? Copy-paste error? Or did you […] "... from SGSN (PS domain) / MSC (CS domain) to an ESME ..." is related to "... message delivery ...", this is not about the direction of Error message itself, because it was already stated above. https://gerrit.osmocom.org/#/c/11836/2/common/chapters/gsup.adoc@1094 PS2, Line 1094: Relay Layer)_ has an unique _message reference (see 8.2.3)_, that > 8.2.3 in this document? then use a <<foo>> link. 8.2.3 in 04.11? > then write the full '3GPP TS 04.11 section 8.2.3' out here, > but rather not break the flow of the sentence with it. In the beginning of this sentence I am referencing "TS GSM 04.11", so it should be clear where to look. I would unconditionally agree with you if "8.2.3" was a part of a separate sentence. > I'd not use italics at all. If they are "given names", capitalize. Thanks, I'll most likely avoid using this. -- To view, visit https://gerrit.osmocom.org/11836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c Gerrit-Change-Number: 11836 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 09:45:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/a234e2a3/attachment.htm>