Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 13 11:20:53 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11668 )

Change subject: cosmetic: lchan: introduce sub-struct lchan->release.*
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@495
PS1, Line 495: 	char *last_error;
Isn't this one related to release too?


https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@518
PS1, Line 518: 		bool release_requested;
Since it's now inside a "release" name, it makes sense to remove the "release_" prefix from this variables:
lchan->release.requested
lchan->release.in_error


https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@523
PS1, Line 523: 		/* RSL error code, RSL_ERR_* */
No enum for RSL_ERR_*? (I know it's not related to this patch).



-- 
To view, visit https://gerrit.osmocom.org/11668
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfddc6010e5d7c309f1a7ed3526b5b635ffeaf11
Gerrit-Change-Number: 11668
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Nov 2018 11:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181113/557ba886/attachment.htm>


More information about the gerrit-log mailing list