<p><a href="https://gerrit.osmocom.org/11668">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h">File include/osmocom/bsc/gsm_data.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@495">Patch Set #1, Line 495:</a> <code style="font-family:monospace,monospace">        char *last_error;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't this one related to release too?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@518">Patch Set #1, Line 518:</a> <code style="font-family:monospace,monospace">         bool release_requested;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since it's now inside a "release" name, it makes sense to remove the "release_" prefix from this variables:<br>lchan->release.requested<br>lchan->release.in_error</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11668/1/include/osmocom/bsc/gsm_data.h@523">Patch Set #1, Line 523:</a> <code style="font-family:monospace,monospace">         /* RSL error code, RSL_ERR_* */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No enum for RSL_ERR_*? (I know it's not related to this patch).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11668">change 11668</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11668"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Icfddc6010e5d7c309f1a7ed3526b5b635ffeaf11 </div>
<div style="display:none"> Gerrit-Change-Number: 11668 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 13 Nov 2018 11:20:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>