Change in osmo-ttcn3-hacks[master]: cosmetic: fix compilation warnings

[Max]

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11557 )

Change subject: cosmetic: fix compilation warnings
......................................................................

cosmetic: fix compilation warnings

Drop 'return' statements after 'mtc.stop' as they cause following
warning from TTCN-3 compiler:
warning: Control never reaches this statement

Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
---
M library/MGCP_Emulation.ttcn
M library/Osmocom_CTRL_Functions.ttcn
2 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn
index c3d09b9..3dfbbc8 100644
--- a/library/MGCP_Emulation.ttcn
+++ b/library/MGCP_Emulation.ttcn
@@ -385,7 +385,6 @@
 	}
 	setverdict(fail, "Couldn't find Expect for CRCX", cmd);
 	mtc.stop;
-	return ret;
 }
 
 private function f_create_expect(ExpectCriteria crit, MGCP_ConnHdlr hdlr)
@@ -459,7 +458,6 @@
 
 	setverdict(fail, "Unknown payload type ", pt);
 	mtc.stop;
-	return "";
 }
 
 }
diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn
index da3b80d..4356ba9 100644
--- a/library/Osmocom_CTRL_Functions.ttcn
+++ b/library/Osmocom_CTRL_Functions.ttcn
@@ -41,12 +41,10 @@
 		[] pt.receive(tr_CtrlMsgError) -> value rx {
 			setverdict(fail, "Error in CTRL GET ", variable, ": ", rx.err.reason);
 			mtc.stop;
-			return "FAIL";
 			}
 		[] T.timeout {
 			setverdict(fail, "Timeout waiting for CTRL GET REPLY ", variable);
 			mtc.stop;
-			return "TIMEOUT";
 			}
 		}
 		return rx.resp.val;
@@ -85,7 +83,6 @@
 		[] T.timeout {
 			setverdict(fail, "Timeout waiting for TRAP ", variable);
 			mtc.stop;
-			return "TIMEOUT";
 			}
 		}
 		return rx.trap.val;

-- 
To view, visit https://gerrit.osmocom.org/11557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/3110f5d7/attachment.htm>