<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11557">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: fix compilation warnings<br><br>Drop 'return' statements after 'mtc.stop' as they cause following<br>warning from TTCN-3 compiler:<br>warning: Control never reaches this statement<br><br>Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5<br>---<br>M library/MGCP_Emulation.ttcn<br>M library/Osmocom_CTRL_Functions.ttcn<br>2 files changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn</span><br><span>index c3d09b9..3dfbbc8 100644</span><br><span>--- a/library/MGCP_Emulation.ttcn</span><br><span>+++ b/library/MGCP_Emulation.ttcn</span><br><span>@@ -385,7 +385,6 @@</span><br><span> }</span><br><span> setverdict(fail, "Couldn't find Expect for CRCX", cmd);</span><br><span> mtc.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- return ret;</span><br><span> }</span><br><span> </span><br><span> private function f_create_expect(ExpectCriteria crit, MGCP_ConnHdlr hdlr)</span><br><span>@@ -459,7 +458,6 @@</span><br><span> </span><br><span> setverdict(fail, "Unknown payload type ", pt);</span><br><span> mtc.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- return "";</span><br><span> }</span><br><span> </span><br><span> }</span><br><span>diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>index da3b80d..4356ba9 100644</span><br><span>--- a/library/Osmocom_CTRL_Functions.ttcn</span><br><span>+++ b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>@@ -41,12 +41,10 @@</span><br><span> [] pt.receive(tr_CtrlMsgError) -> value rx {</span><br><span> setverdict(fail, "Error in CTRL GET ", variable, ": ", rx.err.reason);</span><br><span> mtc.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- return "FAIL";</span><br><span> }</span><br><span> [] T.timeout {</span><br><span> setverdict(fail, "Timeout waiting for CTRL GET REPLY ", variable);</span><br><span> mtc.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- return "TIMEOUT";</span><br><span> }</span><br><span> }</span><br><span> return rx.resp.val;</span><br><span>@@ -85,7 +83,6 @@</span><br><span> [] T.timeout {</span><br><span> setverdict(fail, "Timeout waiting for TRAP ", variable);</span><br><span> mtc.stop;</span><br><span style="color: hsl(0, 100%, 40%);">- return "TIMEOUT";</span><br><span> }</span><br><span> }</span><br><span> return rx.trap.val;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11557">change 11557</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11557"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6210ecf5fcb39f751116ad63a69d2ae8651a60c5 </div>
<div style="display:none"> Gerrit-Change-Number: 11557 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>