Change in osmo-msc[master]: mgcp: hack to keep IuUP working

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue May 29 10:06:46 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9358


Change subject: mgcp: hack to keep IuUP working
......................................................................

mgcp: hack to keep IuUP working

Since change If9a81d057f73150e483286472e73c45e7a453a6d removes the
RTP loopback at the beginning. This also means that the Hack we
do to run the IuUP negotiation via looping back the first few
RTP packets will not work anymore. However, we should keep that
hack as long as we do not have IuUP support in the MGW.

- Start RTP connection in loopback mode for IuUP

Change-Id: I4c7d90de4dc87e8baf7cf4a0c69d0e9e8c92e27b
---
M src/libmsc/msc_mgcp.c
1 file changed, 40 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/58/9358/1

diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c
index 67a2142..c77e389 100644
--- a/src/libmsc/msc_mgcp.c
+++ b/src/libmsc/msc_mgcp.c
@@ -278,10 +278,22 @@
 	struct msgb *msg;
 	int rc;
 
+#ifdef BUILD_IU
+	struct gsm_trans *trans;
+	struct gsm_subscriber_connection *conn;
+#endif
+
 	OSMO_ASSERT(mgcp_ctx);
 	mgcp = mgcp_ctx->mgcp;
 	OSMO_ASSERT(mgcp);
 
+#ifdef BUILD_IU
+	trans = mgcp_ctx->trans;
+	OSMO_ASSERT(trans);
+	conn = trans->conn;
+	OSMO_ASSERT(conn);
+#endif
+
 	/* NOTE: In case of error, we will not be able to perform any DLCX
 	 * operation because until this point we do not have requested any
 	 * endpoint yet. */
@@ -302,6 +314,14 @@
 		return;
 	}
 
+	/* HACK: We put the connection in loopback mode at the beginnig to
+	 * trick the NodeB into doing the IuUP negotiation with itsself.
+	 * this is a hack we need because osmo-mgw does not support IuUP yet */
+#ifdef BUILD_IU
+	if (conn->via_ran == RAN_UTRAN_IU)
+		mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;
+#endif
+
 	msg = mgcp_msg_gen(mgcp, &mgcp_msg);
 	OSMO_ASSERT(msg);
 
@@ -377,10 +397,22 @@
 	struct msgb *msg;
 	int rc;
 
+#ifdef BUILD_IU
+	struct gsm_trans *trans;
+	struct gsm_subscriber_connection *conn;
+#endif
+
 	OSMO_ASSERT(mgcp_ctx);
 	mgcp = mgcp_ctx->mgcp;
 	OSMO_ASSERT(mgcp);
 
+#ifdef BUILD_IU
+	trans = mgcp_ctx->trans;
+	OSMO_ASSERT(trans);
+	conn = trans->conn;
+	OSMO_ASSERT(conn);
+#endif
+
 	switch (event) {
 	case EV_CRCX_RAN_RESP:
 		break;
@@ -405,6 +437,14 @@
 		return;
 	}
 
+	/* HACK: We put the connection in loopback mode at the beginnig to
+	 * trick the NodeB into doing the IuUP negotiation with itsself.
+	 * this is a hack we need because osmo-mgw does not support IuUP yet */
+#ifdef BUILD_IU
+	if (conn->via_ran == RAN_UTRAN_IU)
+		mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;
+#endif
+
 	msg = mgcp_msg_gen(mgcp, &mgcp_msg);
 	OSMO_ASSERT(msg);
 

-- 
To view, visit https://gerrit.osmocom.org/9358
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c7d90de4dc87e8baf7cf4a0c69d0e9e8c92e27b
Gerrit-Change-Number: 9358
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180529/fbff8108/attachment.htm>


More information about the gerrit-log mailing list