<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgcp: hack to keep IuUP working<br><br>Since change If9a81d057f73150e483286472e73c45e7a453a6d removes the<br>RTP loopback at the beginning. This also means that the Hack we<br>do to run the IuUP negotiation via looping back the first few<br>RTP packets will not work anymore. However, we should keep that<br>hack as long as we do not have IuUP support in the MGW.<br><br>- Start RTP connection in loopback mode for IuUP<br><br>Change-Id: I4c7d90de4dc87e8baf7cf4a0c69d0e9e8c92e27b<br>---<br>M src/libmsc/msc_mgcp.c<br>1 file changed, 40 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/58/9358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c</span><br><span>index 67a2142..c77e389 100644</span><br><span>--- a/src/libmsc/msc_mgcp.c</span><br><span>+++ b/src/libmsc/msc_mgcp.c</span><br><span>@@ -278,10 +278,22 @@</span><br><span> struct msgb *msg;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_trans *trans;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_subscriber_connection *conn;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> OSMO_ASSERT(mgcp_ctx);</span><br><span> mgcp = mgcp_ctx->mgcp;</span><br><span> OSMO_ASSERT(mgcp);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ trans = mgcp_ctx->trans;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(trans);</span><br><span style="color: hsl(120, 100%, 40%);">+ conn = trans->conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* NOTE: In case of error, we will not be able to perform any DLCX</span><br><span> * operation because until this point we do not have requested any</span><br><span> * endpoint yet. */</span><br><span>@@ -302,6 +314,14 @@</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* HACK: We put the connection in loopback mode at the beginnig to</span><br><span style="color: hsl(120, 100%, 40%);">+ * trick the NodeB into doing the IuUP negotiation with itsself.</span><br><span style="color: hsl(120, 100%, 40%);">+ * this is a hack we need because osmo-mgw does not support IuUP yet */</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ if (conn->via_ran == RAN_UTRAN_IU)</span><br><span style="color: hsl(120, 100%, 40%);">+ mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> msg = mgcp_msg_gen(mgcp, &mgcp_msg);</span><br><span> OSMO_ASSERT(msg);</span><br><span> </span><br><span>@@ -377,10 +397,22 @@</span><br><span> struct msgb *msg;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_trans *trans;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm_subscriber_connection *conn;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> OSMO_ASSERT(mgcp_ctx);</span><br><span> mgcp = mgcp_ctx->mgcp;</span><br><span> OSMO_ASSERT(mgcp);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ trans = mgcp_ctx->trans;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(trans);</span><br><span style="color: hsl(120, 100%, 40%);">+ conn = trans->conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(conn);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> switch (event) {</span><br><span> case EV_CRCX_RAN_RESP:</span><br><span> break;</span><br><span>@@ -405,6 +437,14 @@</span><br><span> return;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* HACK: We put the connection in loopback mode at the beginnig to</span><br><span style="color: hsl(120, 100%, 40%);">+ * trick the NodeB into doing the IuUP negotiation with itsself.</span><br><span style="color: hsl(120, 100%, 40%);">+ * this is a hack we need because osmo-mgw does not support IuUP yet */</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef BUILD_IU</span><br><span style="color: hsl(120, 100%, 40%);">+ if (conn->via_ran == RAN_UTRAN_IU)</span><br><span style="color: hsl(120, 100%, 40%);">+ mgcp_msg.conn_mode = MGCP_CONN_LOOPBACK;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> msg = mgcp_msg_gen(mgcp, &mgcp_msg);</span><br><span> OSMO_ASSERT(msg);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9358">change 9358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9358"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4c7d90de4dc87e8baf7cf4a0c69d0e9e8c92e27b </div>
<div style="display:none"> Gerrit-Change-Number: 9358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>