This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9320 ) Change subject: bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case ...................................................................... bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case Change-Id: If362a0084de452727cd063063dfb645eca2f9beb --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 2adbb3f..f7f99fa 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -710,23 +710,11 @@ aoip = true; } else { LOGP(DMSC, LOGL_ERROR, "AoIP transport address and CIC missing. " - "Audio will not work.\n"); + "Audio would not work; rejecting\n"); cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING; goto reject; } - /* FIXME: At the moment osmo-bsc does not support any other - * A-Interface other than AoIP. So we must reject all - * assignment requests that are not AoIP compliant. However, - * might support other A-Interface dialects lateron again, - * thats why we preserve the logic around the AoIP detection - * here. */ - if (!aoip) { - LOGP(DMSC, LOGL_ERROR, "Requested A-Interface type is not supported! (AoIP only!)\n"); - cause = GSM0808_CAUSE_REQ_A_IF_TYPE_NOT_SUPP; - goto reject; - } - /* Decode speech codec list (AoIP) */ conn->codec_list_present = false; if (aoip) { -- To view, visit https://gerrit.osmocom.org/9320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If362a0084de452727cd063063dfb645eca2f9beb Gerrit-Change-Number: 9320 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/74e14e7a/attachment.htm>