<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9320">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case<br><br>Change-Id: If362a0084de452727cd063063dfb645eca2f9beb<br>---<br>M src/osmo-bsc/osmo_bsc_bssap.c<br>1 file changed, 1 insertion(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>index 2adbb3f..f7f99fa 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_bssap.c</span><br><span>@@ -710,23 +710,11 @@</span><br><span>                     aoip = true;</span><br><span>                 } else {</span><br><span>                     LOGP(DMSC, LOGL_ERROR, "AoIP transport address and CIC missing. "</span><br><span style="color: hsl(0, 100%, 40%);">-                          "Audio will not work.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                          "Audio would not work; rejecting\n");</span><br><span>                         cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING;</span><br><span>                  goto reject;</span><br><span>                 }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* FIXME: At the moment osmo-bsc does not support any other</span><br><span style="color: hsl(0, 100%, 40%);">-              * A-Interface other than AoIP. So we must reject all</span><br><span style="color: hsl(0, 100%, 40%);">-            * assignment requests that are not AoIP compliant. However,</span><br><span style="color: hsl(0, 100%, 40%);">-             * might support other A-Interface dialects lateron again,</span><br><span style="color: hsl(0, 100%, 40%);">-               * thats why we preserve the logic around the AoIP detection</span><br><span style="color: hsl(0, 100%, 40%);">-             * here. */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (!aoip) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    LOGP(DMSC, LOGL_ERROR, "Requested A-Interface type is not supported! (AoIP only!)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                        cause = GSM0808_CAUSE_REQ_A_IF_TYPE_NOT_SUPP;</span><br><span style="color: hsl(0, 100%, 40%);">-                   goto reject;</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            /* Decode speech codec list (AoIP) */</span><br><span>                conn->codec_list_present = false;</span><br><span>                 if (aoip) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9320">change 9320</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9320"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If362a0084de452727cd063063dfb645eca2f9beb </div>
<div style="display:none"> Gerrit-Change-Number: 9320 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>