Change in osmo-bsc[master]: bsc: Fix check for MSC-side FSM allocation failure

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9316 )

Change subject: bsc: Fix check for MSC-side FSM allocation failure
......................................................................

bsc: Fix check for MSC-side FSM allocation failure

In gscon_fsm_wait_mdcx_bts() we try to allocate conn->user_plane.fi_msc
but then check whether conn->user_plane.fi_bts is set, possibly due to
a copy+paste error.  Let's fix that.

Change-Id: I1f515910f67492257866791588f32b350fadf815
---
M src/libbsc/bsc_subscr_conn_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c
index 176bfbf..5feca69 100644
--- a/src/libbsc/bsc_subscr_conn_fsm.c
+++ b/src/libbsc/bsc_subscr_conn_fsm.c
@@ -658,7 +658,7 @@
 		conn->user_plane.fi_msc =
 		    mgcp_conn_create(conn->network->mgw.client, fi, GSCON_EV_MGW_FAIL_MSC, GSCON_EV_MGW_CRCX_RESP_MSC,
 				     &conn_peer);
-		if (!conn->user_plane.fi_bts) {
+		if (!conn->user_plane.fi_msc) {
 			resp = gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);
 			sigtran_send(conn, resp, fi);
 			osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0);

-- 
To view, visit https://gerrit.osmocom.org/9316
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f515910f67492257866791588f32b350fadf815
Gerrit-Change-Number: 9316
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/c5d1a1d0/attachment.htm>