<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9316">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Fix check for MSC-side FSM allocation failure<br><br>In gscon_fsm_wait_mdcx_bts() we try to allocate conn->user_plane.fi_msc<br>but then check whether conn->user_plane.fi_bts is set, possibly due to<br>a copy+paste error.  Let's fix that.<br><br>Change-Id: I1f515910f67492257866791588f32b350fadf815<br>---<br>M src/libbsc/bsc_subscr_conn_fsm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>index 176bfbf..5feca69 100644</span><br><span>--- a/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>+++ b/src/libbsc/bsc_subscr_conn_fsm.c</span><br><span>@@ -658,7 +658,7 @@</span><br><span>            conn->user_plane.fi_msc =</span><br><span>                     mgcp_conn_create(conn->network->mgw.client, fi, GSCON_EV_MGW_FAIL_MSC, GSCON_EV_MGW_CRCX_RESP_MSC,</span><br><span>                                      &conn_peer);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (!conn->user_plane.fi_bts) {</span><br><span style="color: hsl(120, 100%, 40%);">+            if (!conn->user_plane.fi_msc) {</span><br><span>                   resp = gsm0808_create_assignment_failure(GSM0808_CAUSE_EQUIPMENT_FAILURE, NULL);</span><br><span>                     sigtran_send(conn, resp, fi);</span><br><span>                        osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9316">change 9316</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9316"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I1f515910f67492257866791588f32b350fadf815 </div>
<div style="display:none"> Gerrit-Change-Number: 9316 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>