Change in libosmocore[master]: Add gsm48_cause_coding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 25 17:31:17 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9303 )

Change subject: Add gsm48_cause_coding
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9303/2/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:

https://gerrit.osmocom.org/#/c/9303/2/include/osmocom/gsm/protocol/gsm_04_08.h@1395
PS2, Line 1395: 	GSM48_CAUSE_CODING_GSMPLMNS	= 0x03,
maybe just GSM48_CAUSE_CODING_GSM ? I think that's easier to understand... And it's not like there's different GSM specific values in this enum (and hence requiring further clarification)?



-- 
To view, visit https://gerrit.osmocom.org/9303
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9c8e117ad19f70a3273650d7c0f8280d7bdb9a
Gerrit-Change-Number: 9303
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 25 May 2018 17:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/221b1df9/attachment.htm>


More information about the gerrit-log mailing list